Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-5037 Finish error boundary componentry #298

Merged

Conversation

aaronlademann-wf
Copy link
Contributor

@aaronlademann-wf aaronlademann-wf commented May 17, 2019

Motivation

Changes

  • Remove the temporary JS error boundary in-favor-of the bindings available in Component2
  • Make all the ErrorBoundary componentry mixin-based so that consumers can more easily make any component an error boundary with default behavior(s).
  • Finish tests

Release Notes

Finish error boundary componentry

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review: @greglittlefield-wf @kealjones-wk @joebingham-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

+ Remove the temporary JS error boundary in-favor-of the bindings available in `Component2`
+ Make all the `ErrorBoundary` componentry mixin-based so that consumers can more easily make any component an error boundary with default behavior(s).
+ Finish tests
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf aaronlademann-wf changed the title [WIP] CPLAT-5037 Finish error boundary componentry CPLAT-5037 Finish error boundary componentry May 17, 2019
@aaronlademann-wf aaronlademann-wf marked this pull request as ready for review May 17, 2019 15:34
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@greglittlefield-wf
Copy link
Contributor

+10

@Workiva/release-management-pp

@rmconsole5-wk rmconsole5-wk merged commit 51b4d24 into 3.1.0-wip May 28, 2019
@rmconsole5-wk rmconsole5-wk deleted the 3.1.0/CPLAT-5037_finish-error-boundary-bindings branch May 28, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants