CPLAT-5037 Finish error boundary componentry #298
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Component2
class implements / has js-interop bindings for error boundary lifecycle methods, we can remove the temporary JS error boundary we added for the3.0.0
release.Component2()
annotation has an argument that allows consumers to make any component an error boundary, we need to expose some props / state / component mixins to make it easy for consumers to make custom error boundaries that extend from some (or all) of the standard behaviors that ourErrorBoundary
component implements.Changes
Component2
ErrorBoundary
componentry mixin-based so that consumers can more easily make any component an error boundary with default behavior(s).Release Notes
Finish error boundary componentry
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review: @greglittlefield-wf @kealjones-wk @joebingham-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: