-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CPLAT-4460: Make compatible for use with react.dart 5.0.0-wip #255
CPLAT-4460: Make compatible for use with react.dart 5.0.0-wip #255
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
- switch ref tests to use callbacks - update pubspec to use latest over_react_test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- CI passes
- All tests pass w/ the latest 5.0.0-wip in both DDC and dart2js
+10
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if @aaronlademann-wf wants to do a check, but looks good to me. +1
'key': 'original', | ||
'ref': 'original' | ||
'ref': (ref) { originalRefCalled = true; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were changed to callback refs because string refs are considered legacy and will be deprecated eventually
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+10
@Workiva/release-management-pp
Ultimate problem:
react_dom.render changed its functionality in react 16.
How it was fixed:
Testing suggestions:
5.0.0-wip
branch:Then run
pub run build_runner test -r --delete-conflicting-outputs -- -P dart2js
Potential areas of regression:
Maybe?