Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4460: Make compatible for use with react.dart 5.0.0-wip #255

Merged

Conversation

kealjones-wk
Copy link
Contributor

@kealjones-wk kealjones-wk commented Feb 28, 2019

Ultimate problem:

react_dom.render changed its functionality in react 16.

How it was fixed:

  • remove react_dom.render element throw test since it no longer throws with null passed as the element.

Testing suggestions:

  • CI Passes
  • All tests should pass locally with react-dart 5.0.0-wip branch:
dependency_overrides:
  react:
    git:
      url: git@github.com:cleandart/react-dart.git
      ref: 5.0.0-wip

Then run pub run build_runner test -r --delete-conflicting-outputs -- -P dart2js

Potential areas of regression:

Maybe?


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@kealjones-wk kealjones-wk changed the title CPLAT-4301: Upgrade to use react.dart 5.0.0-wip CPLAT-4301: Make compatible for use with react.dart 5.0.0-wip Mar 1, 2019
@kealjones-wk kealjones-wk changed the title CPLAT-4301: Make compatible for use with react.dart 5.0.0-wip CPLAT-4460: Make compatible for use with react.dart 5.0.0-wip Mar 1, 2019
- switch ref tests to use callbacks
- update pubspec to use latest over_react_test
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • CI passes
  • All tests pass w/ the latest 5.0.0-wip in both DDC and dart2js

+10

Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if @aaronlademann-wf wants to do a check, but looks good to me. +1

'key': 'original',
'ref': 'original'
'ref': (ref) { originalRefCalled = true; }
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were changed to callback refs because string refs are considered legacy and will be deprecated eventually

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@Workiva/release-management-pp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants