CPLAT-4476: Create workaround for ddc bug related to uninitialized maps #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
seanburke-wf
approved these changes
Feb 27, 2019
seanburke-wf
approved these changes
Feb 27, 2019
evanweible-wf
approved these changes
Feb 28, 2019
greglittlefield-wf
approved these changes
Feb 28, 2019
| var customNamespaceProp; | ||
|
|
||
| @Accessor(keyNamespace: 'custom namespace~~', key: 'custom key!') | ||
| var customKeyAndNamespaceProp; |
There was a problem hiding this comment.
#nit most of these props are unused
There was a problem hiding this comment.
(Same goes for the other file like this)
seanburke-wf
approved these changes
Feb 28, 2019
|
+1 |
evanweible-wf
approved these changes
Feb 28, 2019
|
QA +1
Merging into master. |
This was referenced Mar 5, 2019
aaronlademann-wf
added a commit
that referenced
this pull request
Oct 4, 2019
7 tasks
aaronlademann-wf
added a commit
that referenced
this pull request
Oct 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Uninitialized key-value pairs in Maps are treated differently between dart2js compiled output and ddc compiled output. Details: dart-lang/sdk#36052
How it was fixed:
Add a null aware operator and explicitly return null in generated prop/state getters when the
propsorstatemap does not contain a value for the key for any prop/state memberTesting suggestions:
Potential areas of regression:
None