Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPLAT-4326: Check for git changes after build #250

Merged
merged 1 commit into from
Feb 19, 2019
Merged

CPLAT-4326: Check for git changes after build #250

merged 1 commit into from
Feb 19, 2019

Conversation

corwinsheahan-wf
Copy link
Contributor

@corwinsheahan-wf corwinsheahan-wf commented Feb 19, 2019 •
edited
Loading

Ultimate problem:

Since over_react commits generated files to source, we need to verify that there is a clean git diff after a build in CI.

How it was fixed:

Add git diff check to CI

Testing suggestions:

  • CI Passes

Potential areas of regression:

None

FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf @sebastianmalysa-wf @smaifullerton-wk @seanburke-wf

@corwinsheahan-wf corwinsheahan-wf requested a review from a team as a code owner February 19, 2019 17:09
@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

smaifullerton-wk
smaifullerton-wk approved these changes Feb 19, 2019
View reviewed changes
Copy link
Contributor

@smaifullerton-wk smaifullerton-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@corwinsheahan-wf
Copy link
Contributor Author

QA +1

  • CI Passes

Merging into master.
@Workiva/release-management-p

@rmconsole5-wk rmconsole5-wk merged commit 073678b into master Feb 19, 2019
@rmconsole5-wk rmconsole5-wk deleted the add_check_for_build_changes branch February 19, 2019 17:40
This was referenced Mar 5, 2019
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smaifullerton-wk smaifullerton-wk smaifullerton-wk approved these changes

@evanweible-wf evanweible-wf evanweible-wf approved these changes

Assignees
No one assigned
Labels
Merge Requirements Met RM Ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@corwinsheahan-wf @aviary3-wk @evanweible-wf @smaifullerton-wk @rmconsole-wf @rmconsole5-wk