Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CPLAT-4154: Widen over_react_test range #238

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

evanweible-wf
Copy link
Contributor

@evanweible-wf evanweible-wf commented Feb 8, 2019

CPLAT-4154

Issue Status

Ultimate problem:

To support the dual release line for 2.x, we need to widen the over_react_test range on the dart 1 version.

How it was fixed:

Widen it to include over_react_test 2.x.

Testing suggestions:

Potential areas of regression:

n/a


FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @corwinsheahan-wf

@evanweible-wf evanweible-wf requested a review from a team as a code owner February 8, 2019 17:46
@rmconsole6-wk rmconsole6-wk changed the title Widen over_react_test range CPLAT-4154 Widen over_react_test range Feb 8, 2019
@charliekump-wf charliekump-wf changed the title CPLAT-4154 Widen over_react_test range CPLAT-4154: Widen over_react_test range Feb 8, 2019
@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@codecov-io
Copy link

Codecov Report

Merging #238 into master_dart1 will not change coverage.
The diff coverage is n/a.

@@              Coverage Diff              @@
##           master_dart1     #238   +/-   ##
=============================================
  Coverage         90.24%   90.24%           
=============================================
  Files                35       35           
  Lines              1771     1771           
=============================================
  Hits               1598     1598           
  Misses              173      173

@evanweible-wf
Copy link
Contributor Author

QA +1

@Workiva/release-management-p

@rm-astro-wf rm-astro-wf merged commit 7964af3 into master_dart1 Feb 8, 2019
@rm-astro-wf rm-astro-wf deleted the widen_over_react_test_range branch February 8, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants