AF-3085: Transformer is aware of Dart 2 builder compatible boilerplate for Factories

[sebastianmalysa-wf]

Ultimate problem:

The Dart 2 builder compatible boilerplate for factories includes an initialization statement for a UiFactory, e.g.:

@Factory()
- UiFactory<FooProps> Foo;
+ // ignore: undefined_identifier
+ UiFactory<FooProps> Foo = $Foo;

The problem is that the transformer throws an error if a UiFactory declaration is initialized.

How it was fixed:

• Make the transformer aware that Dart 2 builder compatible boiler plate initializes the UiFactory so it doesn't throw an error when initialized correctly
• Ensure (by adding a test) that the transformer will replace the initialization with:
  ([Map backingProps]) => new _$FooPropsImpl(backingProps);

Testing suggestions:

CI passes
Code changes and added tests make sense

---

FYA: @aaronlademann-wf @corwinsheahan-wf @evanweible-wf @greglittlefield-wf

[aviary-wf]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[codecov-io]

Codecov Report

Merging #205 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #205      +/-   ##
==========================================
+ Coverage   94.58%   94.59%   +0.01%     
==========================================
  Files          34       34              
  Lines        1660     1661       +1     
==========================================
+ Hits         1570     1571       +1     
  Misses         90       90

[corwinsheahan-wf]

I think we can have a more helpful error message here. UiFactory is a type so I don't think it should be used as a placeholder here.

[greglittlefield-wf]

Yeah, maybe just include the expected string?

'unless initialized with \$$factoryName...';

[aaronlademann-wf]

This looks good to me. But i'd defer to @greglittlefield-wf for a final signoff.

[greglittlefield-wf]

+1

[evanweible-wf]

QA +1

• CI passes

• All WSD tests passed on Dart 1 using this branch

  diff --git a/pubspec.yaml b/pubspec.yaml
  index 0f69468f3..b0d5cd041 100644
  --- a/pubspec.yaml
  +++ b/pubspec.yaml
   environment:
     sdk: ">=1.24.2 <2.0.0"
  +dependency_overrides:
  +  over_react:
  +    git:
  +      url: git@github.com:sebastianmalysa-wf/over_react.git
  +      ref: AF-3085
   dependencies:
     barback: ">=0.15.2 <=0.15.2+14"
     browser: ">=0.10.0 <0.11.0"

  17:51 +27294: All tests passed!
  

@Workiva/release-management-p