-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AF-3082: transform static meta fields #200
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -256,6 +256,78 @@ main() { | |
reason: 'should preserve existing inheritance'); | ||
}); | ||
|
||
test('with static PropsMeta and StateMeta declaration', () { | ||
final originalPropsMetaLine = 'static const PropsMeta meta = \$metaForFooProps;'; | ||
final originalStateMetaLine = 'static const StateMeta meta = \$metaForFooState;'; | ||
final transformedPropsMetaLine = 'static const PropsMeta meta = \$Props(FooProps);'; | ||
final transformedStateMetaLine = 'static const StateMeta meta = \$State(FooState);'; | ||
|
||
setUpAndGenerate(''' | ||
@Factory() | ||
UiFactory<FooProps> Foo; | ||
|
||
@Props() | ||
class FooProps { | ||
static const PropsMeta meta = \$metaForFooProps; | ||
} | ||
|
||
@State() | ||
class FooState { | ||
static const StateMeta meta = \$metaForFooState; | ||
} | ||
|
||
@Component() | ||
class FooComponent { | ||
render() => null; | ||
} | ||
''' | ||
); | ||
|
||
var transformedSource = transformedFile.getTransformedText(); | ||
expect(transformedSource.contains(originalPropsMetaLine), isFalse); | ||
expect(transformedSource.contains(originalStateMetaLine), isFalse); | ||
expect(transformedSource, contains(transformedPropsMetaLine)); | ||
expect(transformedSource, contains(transformedStateMetaLine)); | ||
}); | ||
|
||
test('with static PropsMeta declaration in PropsMixin', () { | ||
final originalLine = 'static const PropsMeta meta = \$metaForFooPropsMixin;'; | ||
final transformedLine = 'static const PropsMeta meta = \$Props(FooPropsMixin);'; | ||
|
||
setUpAndGenerate(''' | ||
@PropsMixin() | ||
class FooPropsMixin { | ||
static const PropsMeta meta = \$metaForFooPropsMixin; | ||
|
||
Map get props; | ||
} | ||
''' | ||
); | ||
|
||
var transformedSource = transformedFile.getTransformedText(); | ||
expect(transformedSource.contains(originalLine), isFalse); | ||
expect(transformedSource, contains(transformedLine)); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think it might make sense to also verify that the original meta line is not longer present to ensure that the transformer is replacing and not simply adding a line. |
||
}); | ||
|
||
test('with static StateMeta declaration in StateMixin', () { | ||
final originalLine = 'static const StateMeta meta = \$metaForFooStateMixin; '; | ||
final transformedLine = 'static const StateMeta meta = \$State(FooStateMixin);'; | ||
|
||
setUpAndGenerate(''' | ||
@StateMixin() | ||
class FooStateMixin { | ||
static const StateMeta meta = \$metaForFooStateMixin; | ||
|
||
Map get state; | ||
} | ||
''' | ||
); | ||
|
||
var transformedSource = transformedFile.getTransformedText(); | ||
expect(transformedSource.contains(originalLine), isFalse); | ||
expect(transformedSource, contains(transformedLine)); | ||
}); | ||
|
||
group('that subtypes another component, referencing the component class via', () { | ||
test('a simple identifier', () { | ||
preservedLineNumbersTest(''' | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we get one more test added that tests this functionality on
StateMixin
s?