Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-2361 AF-2360 Release over_react 1.26.2 #185

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Sep 14, 2018

Includes:

  • 5fb73f Make rem change sensor container is overflow:hidden so it doesn't interfere with the page layout
    • Testing: verify unit tests for resize sensors still pass.

FYA: @greglittlefield-wf @aaronlademann-wf @kealjones-wk @evanweible-wf @maxwellpeterson-wf

@greglittlefield-wf greglittlefield-wf requested a review from a team as a code owner September 14, 2018 18:51
@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@rmconsole6-wk rmconsole6-wk changed the title Release over_react 1.26.2 AF-2361 AF-2360 Release over_react 1.26.2 Sep 14, 2018
@jeffhall-wk
Copy link

+1

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@codecov-io
Copy link

Codecov Report

Merging #185 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #185      +/-   ##
==========================================
+ Coverage   94.44%   94.44%   +0.01%     
==========================================
  Files          34       34              
  Lines        1616     1617       +1     
==========================================
+ Hits         1526     1527       +1     
  Misses         90       90

@aaronlademann-wf
Copy link
Contributor

QA +1

@Workiva/release-management-pp

@rmconsole2-wf rmconsole2-wf merged commit db0d0ab into master Sep 14, 2018
@aaronlademann-wf aaronlademann-wf deleted the greglittlefield-wf-patch-1 branch September 14, 2018 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants