Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUILDTOOLS-2329: Update Dockerfile to mirror smithy.yaml #147

Merged
merged 1 commit into from
Apr 6, 2018

Conversation

ci-push-wf
Copy link

Overview

In order to improve build isolation, reduce costs, reduce support burden, remove black magic, and improve local consistency, we are migrating away from smithy.yaml and existing Smithy infrastructure to Dockerfile builds supported by off the shelf AWS resources.

Reviewing and merging this PR is the first step in that process; this PR simply copies the contents of your smithy.yaml into a more explicit Dockerfile.
In order to begin running Dockerfile builds you will need to enable Dockerfile builds from your repo configuration page in Smithy.
Once you have enabled Dockerfile builds for your repo, rebuilding the PR build in smithy will trigger the newly enabled Dockefile build.

Expectations

With only a couple of exceptions the behavior of this new Dockerfile should match the existing behavior in your smithy.yaml
Therefore, our expectations are for you to merge this PR as soon as possible. If for any reason you discover a problem post merge, you can disable the new builds and re-enable smithy.yaml builds in your repo configuration page in Smithy

Support/Questions

The migration to Dockerfile builds is our top priority, so please reach out to us if you have any questions, comments, or concerns during this process. Non-urgent questions should go into Confluence Questions and urgent support can be requested in the Support: Build Tools Hipchat Room

More Info

Information about the migration to dockerfile can be found here
A user guide for Dockerfile builds can be found here

@jacehensley-wf

@ci-push-wf ci-push-wf requested a review from a team as a code owner April 6, 2018 03:33
@aviary3-wk
Copy link

Module Findings

No security relevant content detected. Please review for security relevance and request security review as needed.

@codecov-io
Copy link

Codecov Report

Merging #147 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #147   +/-   ##
=======================================
  Coverage   94.51%   94.51%           
=======================================
  Files          33       33           
  Lines        1601     1601           
=======================================
  Hits         1513     1513           
  Misses         88       88

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jayudey-wf
Copy link
Contributor

jayudey-wf commented Apr 6, 2018

QA +1

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
    • new build system working as expected
  • Security review (if required)
  • Unit tests created/updated
  • All unit tests pass

Merging into master.

@jayudey-wf
Copy link
Contributor

@Workiva/release-management-pp

@jayudey-wf jayudey-wf merged commit d22bb0f into master Apr 6, 2018
@jayudey-wf jayudey-wf deleted the smithy_dockerfile_migration branch April 6, 2018 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants