UIP-3156 Widen built_value version constraint #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Module FindingsNo security relevant content detected. Please review for security relevance and request security review as needed. |
|
+1 |
Codecov Report
@@ Coverage Diff @@
## master #145 +/- ##
=======================================
Coverage 94.51% 94.51%
=======================================
Files 33 33
Lines 1601 1601
=======================================
Hits 1513 1513
Misses 88 88 |
| build_runner: ^0.5.0 | ||
| built_value_generator: ^4.2.0 | ||
| build_runner: ^0.6.0 | ||
| built_value_generator: ^5.1.3 |
There was a problem hiding this comment.
@jacehensley-wf should we leave the lower bound intact for build_runner / built_value_generator?
There was a problem hiding this comment.
If I don't update these I cannot pull in the newer version of built_value locally. Since it's just a dev_dependency it's not a big issue to just bump these instead of widening.
evanweible-wf
approved these changes
Mar 14, 2018
greglittlefield-wf
approved these changes
Mar 15, 2018
|
QA +1, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
We need to widen the
built_valueversion constraint.How it was fixed:
built_valuebuild_runnerandbuilt_value_generatorTesting suggestions:
built_value5.x.x is pulled inbuilt_collection3.x.x is pulled inPotential areas of regression: