-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UIP-2924: Add UiPropsMapView #128
UIP-2924: Add UiPropsMapView #128
Conversation
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 94.44% 94.48% +0.05%
==========================================
Files 32 33 +1
Lines 1581 1593 +12
==========================================
+ Hits 1493 1505 +12
Misses 88 88 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@jacehensley-wf should we add a tech-debt follow-up ticket so we remember to remove this from WSD once this is released?
Yup, I can create a follow-up ticket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When pulled into WSD, I get the following error:
error: The name 'UiPropsMixinMapView' is defined in the libraries 'react_util.dart' and 'react_util.dart'. (ambiguous_export at [web_skin_dart] lib/ui_core.dart:12)
which causes a bunch of other analyzer errors.
The error message is misleading, since both WSD and over_react files are named react_util.dart
; the problem is that both lines try to export that class:
export 'package:over_react/over_react.dart';
export 'src/ui_core/util/react_util.dart';
I'm not sure there's a way to export this class in the main over_react entrypoint in a way that's compatible with WSD.
+1 |
QA +10
Merging. |
Ultimate problem:
We should add
UiPropsMapView
How it was fixed:
UiPropsMapView
Testing suggestions:
Potential areas of regression: