UIP-2637 Release over_react 1.16.1 (HOTFIX) #108
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix case where setState and store trigger only result in one render
Ultimate problem:
Currently, when a component calls
setState
at the same time the store triggers, the rerender with the updated store does not take place.How it was fixed:
Use
componentWillReceiveProps
to mark batch redraws instead ofcomponentDidUpdate
.This will mark only components that are getting excessive rerenders from parent components, and not components that have unrelated
setState
calls.Testing suggestions:
Potential areas of regression:
FluxUiComponent batch redrawing.
@Workiva/ui-platform-pp @Workiva/web-platform-pp @kylemcmorrow-wf