Merge pull request #157 from Workiva/1.24.1-rc

AF-258 Release over_react 1.24.1
Workiva · May 11, 2018 · 86aabb2 · 86aabb2
2 parents 33c2982 + b163cd9
commit 86aabb2
Show file tree

Hide file tree

Showing 5 changed files with 23 additions and 11 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,19 @@
 # OverReact Changelog
 
+## 1.24.1
+
+> [Complete `1.24.1` Changeset](https://github.com/Workiva/over_react/compare/1.24.0...1.24.1)
+
+__Dependency Updates__
+
+* w_common `^1.10.0` (was `^1.8.0`)
+* react `^4.4.1` (was `^4.3.0`)
+
+__Tech Debt__
+
+* Address `ReactComponentFactory` deprecation
+* Address `findRenderedComponentWithType` deprecation
+
 ## 1.24.0
 
 > [Complete `1.24.0` Changeset](https://github.com/Workiva/over_react/compare/1.23.1...1.24.0)

diff --git a/README.md b/README.md
@@ -42,7 +42,7 @@
 
     ```yaml
     dependencies:
-      over_react: ^1.24.0
+      over_react: ^1.24.1
     ```
 
 2. Add the `over_react` [transformer] to your `pubspec.yaml`.

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: over_react
-version: 1.24.0
+version: 1.24.1
 description: A library for building statically-typed React UI components using Dart.
 homepage: https://github.com/Workiva/over_react/
 authors:
@@ -16,10 +16,10 @@ dependencies:
   logging: ">=0.11.3+1 <1.0.0"
   meta: ^1.0.4
   path: ^1.4.1
-  react: ^4.3.0
+  react: ^4.4.1
   source_span: ^1.4.0
   transformer_utils: ^0.1.1
-  w_common: ^1.8.0
+  w_common: ^1.10.0
   w_flux: ^2.7.1
   platform_detect: ^1.3.2
   quiver: ">=0.21.4 <=0.28.0" # 0.28.0+ is Dart 2 only

diff --git a/test/over_react/component_declaration/component_base_test.dart b/test/over_react/component_declaration/component_base_test.dart
@@ -979,7 +979,7 @@ class TestComponentProps extends UiProps {
   TestComponentProps([Map props]) : this.props = props ?? ({});
 }
 
-ReactComponentFactory _TestComponentComponentFactory = registerComponent(() => new TestComponentComponent());
+final _TestComponentComponentFactory = registerComponent(() => new TestComponentComponent());
 class TestComponentComponent extends UiComponent<TestComponentProps> {
   @override
   final List<ConsumedProps> consumedProps;
@@ -1016,7 +1016,7 @@ class TestStatefulComponentState extends UiState {
   TestStatefulComponentState([Map state]) : this.state = state ?? ({});
 }
 
-ReactComponentFactory _TestStatefulComponentComponentFactory = registerComponent(() => new TestStatefulComponentComponent());
+final _TestStatefulComponentComponentFactory = registerComponent(() => new TestStatefulComponentComponent());
 class TestStatefulComponentComponent extends UiStatefulComponent<TestStatefulComponentProps, TestStatefulComponentState> {
   @override
   render() {}

diff --git a/test/over_react/util/react_wrappers_test.dart b/test/over_react/util/react_wrappers_test.dart
@@ -266,7 +266,7 @@ main() {
           expect(clone.key, equals(overrideKeyRefProps['key']));
           expect(clone.ref, equals(overrideKeyRefProps['ref']));
 
-          var renderedClone = react_test_utils.findRenderedComponentWithType(renderedHolder, TestComponentFactory);
+          var renderedClone = react_test_utils.findRenderedComponentWithTypeV2(renderedHolder, TestComponentFactory);
 
           Map cloneDartProps = getDartComponent(renderedClone).props;
           expect(cloneDartProps, isNot(anyOf(contains('key'), contains('ref'))),
@@ -1128,8 +1128,7 @@ main() {
 }
 
 /// Helper component for testing a Dart (react-dart) React component with cloneElement.
-final TestComponentFactory =
-    react.registerComponent(() => new TestComponent()) as ReactComponentFactory; // ignore: avoid_as
+final TestComponentFactory = react.registerComponent(() => new TestComponent());
 class TestComponent extends react.Component {
   @override
   render() => Dom.div()();
@@ -1148,8 +1147,7 @@ class PlainObjectStyleMap {
 }
 
 /// Helper component that renders whatever you tell it to. Necessary for rendering components with the 'ref' prop.
-final RenderingContainerComponentFactory =
-    react.registerComponent(() => new RenderingContainerComponent()) as ReactComponentFactory; // ignore: avoid_as
+final RenderingContainerComponentFactory = react.registerComponent(() => new RenderingContainerComponent());
 
 class RenderingContainerComponent extends react.Component {
   @override