Merge pull request #59 from joshbeam-wf/abstract-transition-set-state…

…-warning UIP-2186 Don't call setState when AbstractTransitionComponent is unmounting
Workiva · Mar 31, 2017 · 1986adf · 1986adf
2 parents e3ba50e + b7a2bf4
commit 1986adf
Show file tree

Hide file tree

Showing 2 changed files with 29 additions and 1 deletion.
diff --git a/lib/src/component/abstract_transition.dart b/lib/src/component/abstract_transition.dart
@@ -295,8 +295,16 @@ abstract class AbstractTransitionComponent<T extends AbstractTransitionProps, S
     }
   }
 
+  var _isMounted = false;
+
+  @override
+  void componentDidMount() {
+    _isMounted = true;
+  }
+
   @override
   void componentWillUnmount() {
+    _isMounted = false;
     _cancelTransitionEventListener();
   }
 
@@ -350,7 +358,7 @@ abstract class AbstractTransitionComponent<T extends AbstractTransitionProps, S
       _cancelTransitionEndTimer();
     } else {
       onNextTransitionEnd(() {
-        if (state.transitionPhase == TransitionPhase.HIDING) {
+        if (_isMounted && state.transitionPhase == TransitionPhase.HIDING) {
           setState(newState()
             ..transitionPhase = TransitionPhase.HIDDEN
           );

diff --git a/test/over_react/component/abstract_transition_test.dart b/test/over_react/component/abstract_transition_test.dart
@@ -471,6 +471,18 @@ main() {
         rejectValidationWarning(anything);
       });
     });
+
+    test('does not set hidden state when not mounted', () async {
+      var renderedInstance = render(Transitioner());
+      TransitionerComponent transitioner = getDartComponent(renderedInstance);
+      transitioner.setState(transitioner.newState()..transitionPhase = TransitionPhase.HIDING);
+
+      transitioner.handleHiding();
+      transitioner.componentWillUnmount();
+      await triggerTransitionEnd(transitioner.getTransitionDomNode());
+
+      expect(transitioner.transitionPhasesSet, orderedEquals([TransitionPhase.HIDING]));
+    });
   });
 }
 
@@ -583,4 +595,12 @@ class TransitionerComponent extends AbstractTransitionComponent<TransitionerProp
       props.onHandleHidden();
     }
   }
+
+  List<TransitionPhase> transitionPhasesSet = [];
+
+  @override
+  void setState(dynamic newState, [callback()]) {
+    super.setState(newState, callback);
+    transitionPhasesSet.add(newState.transitionPhase);
+  }
 }