Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove simulated load events #59

Merged
merged 2 commits into from
Oct 7, 2021
Merged

Conversation

robbecker-wf
Copy link
Member

@robbecker-wf robbecker-wf commented Sep 21, 2021

Remove simulated load events and assume that the browser supports the FontFace API https://caniuse.com/mdn-api_fontface
This drops support for old browsers like IE and Edge 12-18.

Changes:

  • Removes all simulated load event code
  • No need for the adobe blank font
  • No checking for the webkit bug when not doing simulated load events
  • Remove tests for simulated events and the ruler class
  • Removes simulated sections of the example app

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@tomconnell-wf
Copy link
Member

I barely remember this repo, but these changes seem reasonable to me.

@robbecker-wf
Copy link
Member Author

github thinks @olesiathoms-wk or @corwinsheahan-wf might make good reviewers

@corwinsheahan-wf
Copy link

Strange, I'm pretty sure I don't even have a single commit to this repo 😬

Copy link
Contributor

@olesiathoms-wk olesiathoms-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I did PR here once during post dart2 cleanup.
Changes lgtm though.

@robbecker-wf
Copy link
Member Author

@pauldanner-wk Would you be able to smoke test in IR viewer to make sure fonts load correctly with this version?

@pauldanner-wk
Copy link

Put it on my TODO list first thing in the morning

@pauldanner-wk
Copy link

QA +1

Screen Shot 2021-10-07 at 8 24 46 AM

Screen Shot 2021-10-07 at 8 22 57 AM

@robbecker-wf
Copy link
Member Author

Woohoo thanks @pauldanner-wk !

@robbecker-wf
Copy link
Member Author

@Workiva/release-management-p

@robbecker-wf robbecker-wf removed the Hold label Oct 7, 2021
@rmconsole2-wf rmconsole2-wf merged commit 9a60bcf into master Oct 7, 2021
Copy link
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole2-wf rmconsole2-wf deleted the remove_simulated_load_events branch October 7, 2021 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants