-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove simulated load events #59
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
I barely remember this repo, but these changes seem reasonable to me. |
github thinks @olesiathoms-wk or @corwinsheahan-wf might make good reviewers |
Strange, I'm pretty sure I don't even have a single commit to this repo 😬 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think I did PR here once during post dart2 cleanup.
Changes lgtm though.
@pauldanner-wk Would you be able to smoke test in IR viewer to make sure fonts load correctly with this version? |
Put it on my TODO list first thing in the morning |
QA +1
|
Woohoo thanks @pauldanner-wk ! |
@Workiva/release-management-p |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1 from RM
Remove simulated load events and assume that the browser supports the FontFace API https://caniuse.com/mdn-api_fontface
This drops support for old browsers like IE and Edge 12-18.
Changes: