Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HY-5924 set dartium expiration #42

Merged
merged 7 commits into from
Jun 22, 2018
Merged

HY-5924 set dartium expiration #42

merged 7 commits into from
Jun 22, 2018

Conversation

robbecker-wf
Copy link
Member

Overview

Extends the dartium expiration so tests do not hang

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on HipChat: InfoSec Forum.

@codecov-wf
Copy link

codecov-wf commented Jun 22, 2018

Current coverage is 88.44% (diff: 100%)

Merging #42 into master will decrease coverage by 0.21%

@@             master        #42   diff @@
==========================================
  Files             4          4          
  Lines           300        303     +3   
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
+ Hits            266        268     +2   
- Misses           34         35     +1   
  Partials          0          0          

Sunburst

Powered by Codecov. Last update 6e9a0c0...3001e96

@rmconsole6-wk rmconsole6-wk changed the title set dartium expiration HY-5924 set dartium expiration Jun 22, 2018
@dustinlessard-wf
Copy link

+10 CI passes!

@robbecker-wf robbecker-wf mentioned this pull request Jun 22, 2018
@robbecker-wf
Copy link
Member Author

robbecker-wf commented Jun 22, 2018

Quality Review Approval: +1 ( aka QA: +1 )

  • Testing instruction
  • Dev +1's
  • Dev/QA +10 with detail of what was tested
  • Unit test created/updated
  • All unit tests pass NA
  • Rosie has run and reports properly the release the ticket will be included in

Merging into master.
@Workiva/release-management-p for merge into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants