-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AF-1837 dart 1 and dart2 compat #38
Merged
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
17bdd95
dart2 prep
robbecker-wf b1d2f67
restore ddc in pubspec
robbecker-wf 82386f9
sdk constraints
robbecker-wf 7c64382
update smithy image
robbecker-wf 936fcd1
remove coverage
robbecker-wf ea9de85
fix dockerfile again
robbecker-wf 00f6f74
Try running CI with Dart 2 ?
robbecker-wf d03ffca
fix CI for dart 2
robbecker-wf e16fe76
leave coverage in but commented, make travis do more work
robbecker-wf 5066872
try to fix travis
robbecker-wf a430d3a
dartfmt test directory
robbecker-wf b2d47dd
Try with the Dart 2 image?
robbecker-wf 5c202ab
1 more time
robbecker-wf e4a0847
go back to how it was
robbecker-wf eb795f9
Merge remote-tracking branch 'origin/master' into dart2
robbecker-wf 94346f6
update dart 2 to latest dev version, run under both versions
robbecker-wf e5e7c67
coverage hanging forever
robbecker-wf 1edf80a
move dry run up top
robbecker-wf 5da66fe
move the pub publish dry run prep to the top too
robbecker-wf 30525a2
don't worry about the .temp dir
robbecker-wf d7e5fa1
remove whitespace ⚪️👽!
robbecker-wf f0a18b0
Merge remote-tracking branch 'origin/master' into dart2
robbecker-wf b8ff2af
latest dart 2, hold off on accepting dart 2 stable in pubspec
robbecker-wf 3ab373e
break up example and test directories
robbecker-wf 2ef8019
remove build.yaml, update dockerfile and pubspec
robbecker-wf 4348516
update dockerfile to dart 2 dev69
robbecker-wf 7f7ad1c
revert dart 2 only changes
robbecker-wf 9140e36
refine dep ranges
robbecker-wf d91a598
update dart sdk version restriction
robbecker-wf e5b7faa
fix dart 2 download url for workiva build
robbecker-wf 79ed152
fix dart analyzer cmd
robbecker-wf 67b507e
dart format
robbecker-wf e7e3c5a
another dockerfile fix
robbecker-wf 7d1f4eb
pubclean and fix dartfmt
robbecker-wf 6b783f0
ugh typo fix
robbecker-wf fdaf36e
alternate pubclean impl
robbecker-wf d147ab7
oops, remove old call to pubclean
robbecker-wf 48d6a50
fix dartfmt cmd
robbecker-wf 47ffae0
just bag building the test directory
robbecker-wf 673e88c
ok, just do dart 1 in Workiva build. Let travis do dart 2.
robbecker-wf ad7d387
include browser tests in travis
robbecker-wf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
remove coverage
- Loading branch information
commit 936fcd14faa99bff6a4d426672a224a952a85ff7
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
removed coverage since there isn't a way to collect coverage under dart 2 yet