Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AF-1837 dart 1 and dart2 compat #38

Merged
merged 41 commits into from
Aug 1, 2018
Merged
Changes from 1 commit
Commits
Show all changes
41 commits
Select commit Hold shift + click to select a range
17bdd95
dart2 prep
robbecker-wf May 17, 2018
b1d2f67
restore ddc in pubspec
robbecker-wf May 17, 2018
82386f9
sdk constraints
robbecker-wf May 17, 2018
7c64382
update smithy image
robbecker-wf May 17, 2018
936fcd1
remove coverage
robbecker-wf May 17, 2018
ea9de85
fix dockerfile again
robbecker-wf May 17, 2018
00f6f74
Try running CI with Dart 2 ?
robbecker-wf May 29, 2018
d03ffca
fix CI for dart 2
robbecker-wf May 29, 2018
e16fe76
leave coverage in but commented, make travis do more work
robbecker-wf May 29, 2018
5066872
try to fix travis
robbecker-wf May 29, 2018
a430d3a
dartfmt test directory
robbecker-wf May 29, 2018
b2d47dd
Try with the Dart 2 image?
robbecker-wf May 29, 2018
5c202ab
1 more time
robbecker-wf May 29, 2018
e4a0847
go back to how it was
robbecker-wf May 29, 2018
eb795f9
Merge remote-tracking branch 'origin/master' into dart2
robbecker-wf Jun 14, 2018
94346f6
update dart 2 to latest dev version, run under both versions
robbecker-wf Jun 14, 2018
e5e7c67
coverage hanging forever
robbecker-wf Jun 14, 2018
1edf80a
move dry run up top
robbecker-wf Jun 14, 2018
5da66fe
move the pub publish dry run prep to the top too
robbecker-wf Jun 14, 2018
30525a2
don't worry about the .temp dir
robbecker-wf Jun 14, 2018
d7e5fa1
remove whitespace ⚪️👽!
robbecker-wf Jun 14, 2018
f0a18b0
Merge remote-tracking branch 'origin/master' into dart2
robbecker-wf Jun 22, 2018
b8ff2af
latest dart 2, hold off on accepting dart 2 stable in pubspec
robbecker-wf Jun 22, 2018
3ab373e
break up example and test directories
robbecker-wf Jul 18, 2018
2ef8019
remove build.yaml, update dockerfile and pubspec
robbecker-wf Jul 18, 2018
4348516
update dockerfile to dart 2 dev69
robbecker-wf Jul 18, 2018
7f7ad1c
revert dart 2 only changes
robbecker-wf Jul 18, 2018
9140e36
refine dep ranges
robbecker-wf Jul 23, 2018
d91a598
update dart sdk version restriction
robbecker-wf Jul 30, 2018
e5b7faa
fix dart 2 download url for workiva build
robbecker-wf Jul 30, 2018
79ed152
fix dart analyzer cmd
robbecker-wf Jul 30, 2018
67b507e
dart format
robbecker-wf Jul 30, 2018
e7e3c5a
another dockerfile fix
robbecker-wf Jul 30, 2018
7d1f4eb
pubclean and fix dartfmt
robbecker-wf Jul 30, 2018
6b783f0
ugh typo fix
robbecker-wf Jul 30, 2018
fdaf36e
alternate pubclean impl
robbecker-wf Jul 30, 2018
d147ab7
oops, remove old call to pubclean
robbecker-wf Jul 30, 2018
48d6a50
fix dartfmt cmd
robbecker-wf Jul 30, 2018
47ffae0
just bag building the test directory
robbecker-wf Jul 30, 2018
673e88c
ok, just do dart 1 in Workiva build. Let travis do dart 2.
robbecker-wf Jul 30, 2018
ad7d387
include browser tests in travis
robbecker-wf Jul 30, 2018
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove coverage
  • Loading branch information
robbecker-wf committed May 17, 2018
commit 936fcd14faa99bff6a4d426672a224a952a85ff7
1 change: 0 additions & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
@@ -20,7 +20,6 @@ RUN echo "Starting the script sections" && \
pub run dart_dev analyze && \
pub run dart_dev format --check && \
xvfb-run -s '-screen 0 1024x768x24' pub run dart_dev test --web-compiler=dartdevc -p chrome && \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed coverage since there isn't a way to collect coverage under dart 2 yet

xvfb-run -s '-screen 0 1024x768x24' pub run dart_dev coverage --no-html && \
pub run dart_dev docs --no-open && \
tar czvf api.tar.gz -C doc/api . && \
pub run dart_build test && \