Fix out of range exception

WorkingRobot · Jul 4, 2024 · 7363b81 · 7363b81 · github-actions · Jul 4, 2024
1 parent 65d01ae
commit 7363b81
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 11 deletions.
diff --git a/Craftimizer/Windows/SynthHelper.cs b/Craftimizer/Windows/SynthHelper.cs
@@ -372,6 +372,7 @@ private void DrawMacroInfo()
                     if (!effect.IsIndefinite())
                     {
                         ImGui.SetCursorPosY(ImGui.GetCursorPosY() - durationShift);
+                        ImGui.SetCursorPosX(ImGui.GetCursorPosX() + 1);
                         ImGuiUtils.TextCentered($"{effects.GetDuration(effect)}", size.X);
                     }
                 }

diff --git a/Solver/MCTS.cs b/Solver/MCTS.cs
@@ -191,18 +191,21 @@ private Node Select()
         var currentCompletionState = expandedNode.State.SimulationCompletionState;
         var currentActions = expandedNode.State.AvailableActions;
 
-        byte actionCount = 0;
-        var actions = actionBuffer[..Math.Min(config.MaxStepCount - currentState.ActionCount, config.MaxRolloutStepCount)];
-        while (SimulationNode.GetCompletionState(currentCompletionState, currentActions) == CompletionState.Incomplete &&
-            actionCount < actions.Length)
+        if (currentState.ActionCount < config.MaxStepCount)
         {
-            var nextAction = currentActions.SelectRandom(random);
-            actions[actionCount++] = nextAction;
-            currentState = simulator.ExecuteUnchecked(currentState, nextAction);
-            currentCompletionState = simulator.CompletionState;
-            if (currentCompletionState != CompletionState.Incomplete)
-                break;
-            currentActions = simulator.AvailableActionsHeuristic(true);
+            var actions = actionBuffer[..Math.Min(config.MaxStepCount - currentState.ActionCount, config.MaxRolloutStepCount)];
+            byte actionCount = 0;
+            while (SimulationNode.GetCompletionState(currentCompletionState, currentActions) == CompletionState.Incomplete &&
+                actionCount < actions.Length)
+            {
+                var nextAction = currentActions.SelectRandom(random);
+                actions[actionCount++] = nextAction;
+                currentState = simulator.ExecuteUnchecked(currentState, nextAction);
+                currentCompletionState = simulator.CompletionState;
+                if (currentCompletionState != CompletionState.Incomplete)
+                    break;
+                currentActions = simulator.AvailableActionsHeuristic(true);
+            }
         }
 
         var score = SimulationNode.CalculateScoreForState(currentState, currentCompletionState, config) ?? 0;
Benchmark suite	Current: `7363b81`	Previous: `7ad073a`	Ratio
`Craftimizer.Benchmark.Bench.Solve(State: 4D905E7E, Config: A52FEBEA)`	`106662693.84615384` ns (`± 536866.3052309278`)
`Craftimizer.Benchmark.Bench.Solve(State: C62039FC, Config: A52FEBEA)`	`98629663.33333333` ns (`± 399177.7539070585`)