Skip to content

Commit

Permalink
clean up - no behavior changes
Browse files Browse the repository at this point in the history
  • Loading branch information
iandunn committed Mar 31, 2023
1 parent 0ba5a28 commit 36079b2
Showing 1 changed file with 10 additions and 33 deletions.
43 changes: 10 additions & 33 deletions mu-plugins/blocks/global-header-footer/postcss/header/header.pcss
Original file line number Diff line number Diff line change
Expand Up @@ -15,57 +15,34 @@ html {
* @link https://github.com/WordPress/wporg-mu-plugins/issues/371.
*/
html.has-modal-open {
/* Override https://github.com/WordPress/gutenberg/pull/49369/ on other non-mobile breakpoints to avoid gap on right side of search modal. */
/*
* Hotfix for https://github.com/WordPress/gutenberg/pull/49369/. Otherwise the styles below will break when
* we update. Remove this after we install the update
*/
position: fixed;

/*
* Override https://github.com/WordPress/gutenberg/pull/49369/. On desktop views it causes a gap to the right
* of the search modal when it's open.
*/
position: static;

@media (--mobile-only) {
/*position: fixed;*/ /* hotfix for https://github.com/WordPress/gutenberg/pull/49369/. remove when in stable release. */
/* if leave ^ enabled, then there's a gap at the bottom of the page where <main> shows through
if disable, then safari scroll a little, but it's not visible above the fold
*/

height: 100lvh;

overflow: hidden;
/* todo
maybe set bg color grey to override
try dvh height
try setting height less than 100vh
add fixed to header in case that helps
*/

& body{
/*
none necessary
position: fixed;
height: 100vh;
overflow: hidden;*/

background: var(--wp--preset--color--charcoal-1);
}

& body:not(.admin-bar) {
background: var(--wp--preset--color--charcoal-5);
}


& .wp-site-blocks {
/* all of this necessary */
position: fixed;
height: 100vh;
overflow: hidden;
}

& .wp-block-navigation__responsive-container {
/* need to disable overflow vis from search.pcss? */

height: 100vh;

/*
these not necessary
position: fixed;
overflow: hidden;*/
}

& #wpadminbar {
Expand Down

0 comments on commit 36079b2

Please sign in to comment.