Fix progress reporting during Playground load #1915
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this change, the service worker was not making the response available to consumers until the response was placed in the offline cache. It looks like the entire response had to be buffered before consumers had a chance to observe response progress, and at that point, there was no progress to observe because the download was complete. This updates service worker request caching so that responses are made available downstream before caching is complete.
|
Lovely ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Prior to this change, the service worker was not making the response available to consumers until the response was placed in the offline cache. It looks like the entire response had to be buffered before consumers had a chance to observe response progress, and at that point, there was no progress to observe because the download was complete.
Props to @adamziel for noticing this cause.
Fixes #1667
Implementation details
This updates service worker request caching so that responses are made available downstream before caching is complete.
Testing Instructions (or ideally a Blueprint)