[Website] Restore the single-click "Edit Settings" flow #1854
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -13,7 +13,7 @@ test('should reflect the URL update from the navigation bar in the WordPress sit | |
| website, | ||
| }) => { | ||
| await website.goto('./?url=/wp-admin/'); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await expect(website.page.locator('input[value="/wp-admin/"]')).toHaveValue( | ||
| '/wp-admin/' | ||
| ); | ||
|
|
@@ -23,74 +23,98 @@ test('should correctly load /wp-admin without the trailing slash', async ({ | |
| website, | ||
| }) => { | ||
| await website.goto('./?url=/wp-admin'); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await expect(website.page.locator('input[value="/wp-admin/"]')).toHaveValue( | ||
| '/wp-admin/' | ||
| ); | ||
| }); | ||
|
|
||
| test('should switch between sites', async ({ website, browserName }) => { | ||
| test.skip( | ||
| browserName === 'webkit', | ||
| `This test relies on OPFS which isn't available in Playwright's flavor of Safari.` | ||
| ); | ||
|
|
||
| await website.goto('./'); | ||
|
|
||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect(website.page.getByText('Save')).toBeEnabled(); | ||
| await website.page.getByText('Save').click(); | ||
| // We shouldn't need to explicitly call .waitFor(), but the test fails without it. | ||
| // Playwright logs that something "intercepts pointer events", that's probably related. | ||
| await website.page.getByText('Save in this browser').waitFor(); | ||
| await website.page.getByText('Save in this browser').click({ force: true }); | ||
| await expect( | ||
| website.page.locator('[aria-current="page"]') | ||
| ).not.toContainText('Temporary Playground', { | ||
| // Saving the site takes a while on CI | ||
| timeout: 90000, | ||
| }); | ||
| await expect(website.page.getByLabel('Playground title')).not.toContainText( | ||
| 'Temporary Playground' | ||
| ); | ||
|
|
||
| await website.page | ||
| .locator('button') | ||
| .filter({ hasText: 'Temporary Playground' }) | ||
| .click(); | ||
|
|
||
| await expect(website.page.locator('[aria-current="page"]')).toContainText( | ||
| 'Temporary Playground' | ||
| ); | ||
| await expect(website.page.getByLabel('Playground title')).toContainText( | ||
| 'Temporary Playground' | ||
| ); | ||
| }); | ||
|
|
||
| SupportedPHPVersions.forEach(async (version) => { | ||
| /** | ||
| * WordPress 6.6 dropped support for PHP 7.0 and 7.1 and won't load on these versions. | ||
| * Therefore, we're skipping the test for these versions. | ||
|
There was a problem hiding this comment. It would be good for our WordPress builds to encode minimum supported PHP versions and at least warn about incompatible version in UI. It looks like the WordPress.org API does list the minimum supported PHP version for each release. From {
"response": "development",
"download": "https:\/\/downloads.wordpress.org\/release\/wordpress-6.7-beta1.zip",
"locale": "en_US",
"packages": {
"full": "https:\/\/downloads.wordpress.org\/release\/wordpress-6.7-beta1.zip",
"no_content": false,
"new_bundled": false,
"partial": false,
"rollback": false
},
"current": "6.7-beta1",
"version": "6.7-beta1",
"php_version": "7.2.24",
"mysql_version": "5.5.5",
"new_bundled": "6.4",
"partial_version": false
}If we had that info, we could stop hardcoding PHP versions here. Created an issue for adding the info: |
||
| * @see https://make.wordpress.org/core/2024/04/08/dropping-support-for-php-7-1/ | ||
| */ | ||
| if (['7.0', '7.1'].includes(version)) { | ||
| return; | ||
| } | ||
|
|
||
| test(`should switch PHP version to ${version}`, async ({ website }) => { | ||
| await website.goto(`./`); | ||
| await website.ensureSiteManagerIsOpen(); | ||
| await website.page.getByLabel('PHP version').selectOption(version); | ||
| await website.page | ||
| .getByText('Apply Settings & Reset Playground') | ||
| .click(); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect(website.page.getByLabel('PHP version')).toHaveValue( | ||
| version | ||
| ); | ||
| await expect( | ||
| website.page.getByLabel('Load PHP extensions') | ||
| ).toBeChecked(); | ||
| }); | ||
|
|
||
| test(`should not load additional PHP ${version} extensions when not requested`, async ({ | ||
| website, | ||
| }) => { | ||
| await website.goto('./'); | ||
| await website.ensureSiteManagerIsOpen(); | ||
| await website.page.getByLabel('PHP version').selectOption(version); | ||
| await website.page.getByLabel('Load PHP extensions').uncheck(); | ||
| await website.page | ||
| .getByText('Apply Settings & Reset Playground') | ||
| .click(); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect(website.page.getByLabel('PHP version')).toHaveValue( | ||
| version | ||
| ); | ||
| await expect( | ||
| website.page.getByLabel('Load PHP extensions') | ||
| ).not.toBeChecked(); | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -102,13 +126,19 @@ Object.keys(MinifiedWordPressVersions) | |
| website, | ||
| }) => { | ||
| await website.goto('./'); | ||
| await website.ensureSiteManagerIsOpen(); | ||
| await website.page | ||
| .getByLabel('WordPress version') | ||
| .selectOption(version); | ||
| await website.page | ||
| .getByText('Apply Settings & Reset Playground') | ||
| .click(); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect( | ||
| website.page.getByLabel('WordPress version') | ||
| ).toHaveValue(version); | ||
| }); | ||
| }); | ||
|
|
||
|
|
@@ -117,43 +147,39 @@ test('should display networking as inactive by default', async ({ | |
| }) => { | ||
| await website.goto('./'); | ||
| await website.ensureSiteManagerIsOpen(); | ||
| await expect(website.page.getByLabel('Network access')).not.toBeChecked(); | ||
| }); | ||
|
|
||
| test('should display networking as active when networking is enabled', async ({ | ||
| website, | ||
| }) => { | ||
| await website.goto('./?networking=yes'); | ||
| await website.ensureSiteManagerIsOpen(); | ||
| await expect(website.page.getByLabel('Network access')).toBeChecked(); | ||
| }); | ||
|
|
||
| test('should enable networking when requested', async ({ website }) => { | ||
| await website.goto('./'); | ||
|
|
||
| await website.ensureSiteManagerIsOpen(); | ||
| await website.page.getByLabel('Network access').check(); | ||
| await website.page.getByText('Apply Settings & Reset Playground').click(); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect(website.page.getByLabel('Network access')).toBeChecked(); | ||
| }); | ||
|
|
||
| test('should disable networking when requested', async ({ website }) => { | ||
| await website.goto('./?networking=yes'); | ||
|
|
||
| await website.ensureSiteManagerIsOpen(); | ||
| await website.page.getByLabel('Network access').uncheck(); | ||
| await website.page.getByText('Apply Settings & Reset Playground').click(); | ||
| await website.ensureSiteManagerIsClosed(); | ||
| await website.ensureSiteManagerIsOpen(); | ||
|
|
||
| await expect(website.page.getByLabel('Network access')).not.toBeChecked(); | ||
| }); | ||
|
|
||
| test('should display PHP output even when a fatal error is hit', async ({ | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I love how addressing elements of a page for E2E tests has overlapping concerns with A11Y (or maybe it is better said the other way around A11Y -> E2E-testability)