mirrored from git://develop.git.wordpress.org/
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't prepare the response body for HEAD requests #7970
Open
anton-vlasenko
wants to merge
51
commits into
WordPress:trunk
Choose a base branch
from
anton-vlasenko:add/short-circuit-head-requests
base: trunk
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,677
−303
Open
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
955a3a4
Short circuit the WP_REST_Posts_Controller controller.
anton-vlasenko 48a4b07
Short circuit the WP_REST_Comments_Controller controller.
anton-vlasenko d9b13f2
Short circuit the WP_REST_Terms_Controller controller.
anton-vlasenko 301fa88
Short circuit the WP_REST_Users_Controller controller.
anton-vlasenko 6cdcf6b
Short circuit the WP_REST_Taxonomies_Controller controller.
anton-vlasenko bbcb099
Use the upper-case http method name (per https://core.trac.wordpress.…
anton-vlasenko 79c6143
Add PHPUnit tests for the WP_Request::is_method() method.
anton-vlasenko 6db28eb
Better test method name.
anton-vlasenko 8fa6aa4
Rename the test methods.
anton-vlasenko 98c03bb
Data providers should always be declared as static. Props @swisspidy.
anton-vlasenko dd8a5ec
Disable priming meta for HEAD requests to improve performance.
anton-vlasenko 19074f9
Fix CS and typos.
anton-vlasenko 3de5947
Don't prepare the response body for HEAD requests in WP_Test_REST_Pos…
anton-vlasenko ce06631
Move the check for HEAD requests to ::prepare_item_for_response() met…
anton-vlasenko 77d7c92
Short circuit the WP_REST_Block_Pattern_Categories_Controller control…
anton-vlasenko b9360fd
Short circuit the WP_REST_Block_Types_Controller controller.
anton-vlasenko 1063c67
Fix CS.
anton-vlasenko 5512e09
Add unit tests.
anton-vlasenko e81fac3
Short circuit the WP_REST_Font_Collections_Controller controller.
anton-vlasenko 0cd6883
Add unit tests.
anton-vlasenko 02aec99
Short circuit the WP_REST_Revisions_Controller controller.
anton-vlasenko fc1460b
Add unit tests.
anton-vlasenko 4627401
Short circuit the WP_REST_Global_Styles_Revisions_Controller controller.
anton-vlasenko f4a2af4
Short circuit the WP_REST_Global_Styles_Revisions_Controller controller.
anton-vlasenko a0bc222
Add unit tests.
anton-vlasenko 4000e22
Fix the failing unit test.
anton-vlasenko 5ce28ef
Add unit tests.
anton-vlasenko 05da914
Short circuit the WP_REST_Search_Controller controller.
anton-vlasenko 4dc9092
Fix the WP_Test_REST_Posts_Controller::test_get_items_pagination_head…
anton-vlasenko bdd97cf
Short circuit the WP_REST_Sidebars_Controller controller.
anton-vlasenko 6772204
Remove non-existent test method parameter.
anton-vlasenko e0c6424
Add unit tests.
anton-vlasenko f79d0dd
Fix backward compatibility issues in the WP_REST_Font_Collections_Con…
anton-vlasenko be26c39
Short circuit the WP_REST_Templates_Controller controller.
anton-vlasenko 8c384d4
Add unit tests.
anton-vlasenko eb7d4d2
Short circuit the WP_REST_Widget_Types_Controller controller.
anton-vlasenko 25b39a3
Fix the unit test.
anton-vlasenko 792128f
Add unit tests.
anton-vlasenko bd9bae3
Short circuit the WP_REST_Widgets_Controller controller.
anton-vlasenko e6ed30f
Add unit tests.
anton-vlasenko 61010ec
Unify inline comments.
anton-vlasenko dccc30d
Short circuit the WP_REST_Autosaves_Controller controller.
janusqa 1fbaeb4
Add unit tests.
anton-vlasenko 85ce233
Short-circuit the WP_REST_Template_Autosaves_Controller and WP_REST_T…
anton-vlasenko 9d4b831
Rename test methods.
anton-vlasenko cb42502
Add unit tests.
anton-vlasenko 021c2c5
Add unit tests.
anton-vlasenko 72a3a1e
Short circuit the WP_REST_Pattern_Directory_Controller controller.
anton-vlasenko 4765127
Update src/wp-includes/rest-api/endpoints/class-wp-rest-font-collecti…
anton-vlasenko fa48424
Fix code style.
anton-vlasenko fd60b44
Fix the failing PHPUnit tests.
anton-vlasenko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we avoid priming comment meta here as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think we should avoid priming comment meta here.
Fixed in 294584e