Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HttpOnly for Server-side Cookies #7240

Closed
wants to merge 3 commits into from
Closed

HttpOnly for Server-side Cookies #7240

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f192996
HttpOnly flags added to setcookie() for `TEST_COOKIE` and `wp-postpas…
Kevinlearynet Aug 26, 2024
9f7fa31
retrigger checks
Kevinlearynet Aug 29, 2024
90f6ad8
Merge branch 'trunk' into feature/httponly-cookies
johnbillion Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/wp-login.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -528,14 +528,14 @@ function wp_login_viewport_meta() {

// Set a cookie now to see if they are supported by the browser.
$secure = ( 'https' === parse_url( wp_login_url(), PHP_URL_SCHEME ) );
setcookie( TEST_COOKIE, 'WP Cookie check', 0, COOKIEPATH, COOKIE_DOMAIN, $secure );
setcookie( TEST_COOKIE, 'WP Cookie check', 0, COOKIEPATH, COOKIE_DOMAIN, $secure, true );

if ( SITECOOKIEPATH !== COOKIEPATH ) {
setcookie( TEST_COOKIE, 'WP Cookie check', 0, SITECOOKIEPATH, COOKIE_DOMAIN, $secure );
setcookie( TEST_COOKIE, 'WP Cookie check', 0, SITECOOKIEPATH, COOKIE_DOMAIN, $secure, true );
}

if ( isset( $_GET['wp_lang'] ) ) {
setcookie( 'wp_lang', sanitize_text_field( $_GET['wp_lang'] ), 0, COOKIEPATH, COOKIE_DOMAIN, $secure );
setcookie( 'wp_lang', sanitize_text_field( $_GET['wp_lang'] ), 0, COOKIEPATH, COOKIE_DOMAIN, $secure, true );
}

/**
Expand Down Expand Up @@ -791,7 +791,7 @@ function wp_login_viewport_meta() {
$secure = false;
}

setcookie( 'wp-postpass_' . COOKIEHASH, $hasher->HashPassword( wp_unslash( $_POST['post_password'] ) ), $expire, COOKIEPATH, COOKIE_DOMAIN, $secure );
setcookie( 'wp-postpass_' . COOKIEHASH, $hasher->HashPassword( wp_unslash( $_POST['post_password'] ) ), $expire, COOKIEPATH, COOKIE_DOMAIN, $secure, true );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I support setting the test cookie and wp_lang cookie to HttpOnly, but I don't think it's safe to do it for the post password cookie. There's too high an opportunity for it to break either JavaScript that reads the value of the cookie, or Ajax handlers in PHP that read the value of the cookie, both of which would no longer be able to do so.

Let's revert this change but keep the other changes.


wp_safe_redirect( wp_get_referer() );
exit;
Expand Down
Loading