-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Global Styles: Fix blocks custom css selectors and empty rules #7097
Global Styles: Fix blocks custom css selectors and empty rules #7097
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN:
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is testing well for me:
✅ The logic looks good to me (only applies regex to the already split out nested selector, and appends any matched pseudo elements to the end)
✅ Test coverage looks good
✅ Works nicely on the site frontend
✅ Existing rules that don't use a selector (root CSS) continue to work as expected (e.g. placing background-color: red
under the Heading block's Advanced area works as on trunk
)
As discussed over in WordPress/gutenberg#63980 (comment), this fix focuses on fixing a particular issue rather than handling all possible cases in CSS 👍
LGTM! 🚀
I tested along the lines of WordPress/gutenberg#63980 also LGTM Thanks for reviewing so quickly, folks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- ✅ Tests well for me (see test report)
- ✅ All PHP changes from the original Gutenberg PR are included.
LGTM for commit 👍
Committed to |
Syncs the changes from WordPress/gutenberg#63980
These updates include the PHP fixes for empty CSS rules and invalid selectors for Global Styles custom CSS for blocks.
Please note: JS package updates will be required to resolve the issue in the editor.
Testing Instructions
&::before { content: 'Foo' }
Screenshots or screencast
Trac ticket: https://core.trac.wordpress.org/ticket/61769
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.