Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global Styles: Fix blocks custom css selectors and empty rules #7097

Conversation

aaronrobertshaw
Copy link

Syncs the changes from WordPress/gutenberg#63980

These updates include the PHP fixes for empty CSS rules and invalid selectors for Global Styles custom CSS for blocks.

Please note: JS package updates will be required to resolve the issue in the editor.

Testing Instructions

  1. In the site editor navigate to Styles > Blocks > Heading > Advanced
  2. Add the following into the Custom CSS field: &::before { content: 'Foo' }
  3. Ensure the page being edited has a heading block
  4. Save and view the frontend
  5. Confirm the heading block has a pseudo element displaying the word "Foo".

Screenshots or screencast

Before After
Screenshot 2024-07-26 at 10 22 19 AM Screenshot 2024-07-26 at 3 09 48 PM
Before After
Screenshot 2024-07-26 at 3 07 50 PM Screenshot 2024-07-26 at 3 09 01 PM

Trac ticket: https://core.trac.wordpress.org/ticket/61769


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

Copy link

github-actions bot commented Jul 26, 2024

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Core Committers: Use this line as a base for the props when committing in SVN:

Props aaronrobertshaw, andrewserong, aristath, ramonopoly.

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

Copy link

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

  • The Plugin and Theme Directories cannot be accessed within Playground.
  • All changes will be lost when closing a tab with a Playground instance.
  • All changes will be lost when refreshing the page.
  • A fresh instance is created each time the link below is clicked.
  • Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
    it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

Copy link
Contributor

@andrewserong andrewserong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is testing well for me:

image

✅ The logic looks good to me (only applies regex to the already split out nested selector, and appends any matched pseudo elements to the end)
✅ Test coverage looks good
✅ Works nicely on the site frontend
✅ Existing rules that don't use a selector (root CSS) continue to work as expected (e.g. placing background-color: red under the Heading block's Advanced area works as on trunk)

As discussed over in WordPress/gutenberg#63980 (comment), this fix focuses on fixing a particular issue rather than handling all possible cases in CSS 👍

LGTM! 🚀

@ramonjd
Copy link
Member

ramonjd commented Aug 1, 2024

I tested along the lines of WordPress/gutenberg#63980 also LGTM

Thanks for reviewing so quickly, folks!

Copy link
Contributor

@hellofromtonya hellofromtonya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for commit 👍

@hellofromtonya
Copy link
Contributor

Committed to trunk via https://core.trac.wordpress.org/changeset/58896.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants