Update @wordpress npm packages. #626
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
reviewed
Oct 20, 2020
| @@ -0,0 +1,196 @@ | |||
| <?php | |||
There was a problem hiding this comment.
Let's move this file to src/wp-includes/block-supports/class-wp-block-supports.php.
There was a problem hiding this comment.
I actually reverted this change, I believe it's better there with the other classes and src/wp-includes/block-supports only includes the actual block supports not the framework for it.
63c6ee5 to
26df7a5
Compare
|
Ok this is looking good to me now, I'm going to proceed and commit this patch. |
…press-develop into update/npm-packages
youknowriad
reviewed
Oct 20, 2020
This was referenced Oct 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates @WordPress npm packages to their latest versions, prior to 5.6 Beta 1.
Trac ticket: https://core.trac.wordpress.org/ticket/51570
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.