TT4: remove the pattern from the home template #6170
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the pattern from the home template and instead replaces it directly with its contents.
This was introduced in this PR. Creating the pattern was needed to solve what the PR was stating (we need the Home Business pattern to show on the template replacement flows) but we don't need to use it in the template, and the code repetition (which is minor) is better than having to do a an extra pattern replacement.
To test this PR, check that the home page is unchanged and that creating a new template still shows the home page pattern (by creating a template for the front page, for example)
Trac ticket:
https://core.trac.wordpress.org/ticket/60620
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.