Try/rest global styles controller inherits post controller

[spacedmonkey]

Trac ticket: https://core.trac.wordpress.org/ticket/60131

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @jonnynews.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

Core SVN

If you're a Core Committer, use this list when committing to wordpress-develop in SVN:

Props: ramonopoly, spacedmonkey, mukesh27.

GitHub Merge commits

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: jonnynews.

Co-authored-by: ramonjd <ramonopoly@git.wordpress.org>
Co-authored-by: spacedmonkey <spacedmonkey@git.wordpress.org>
Co-authored-by: mukeshpanchal27 <mukesh27@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[github-actions]

Test using WordPress Playground

The changes in this pull request can previewed and tested using a WordPress Playground instance.

WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser.

Some things to be aware of

• The Plugin and Theme Directories cannot be accessed within Playground.
• All changes will be lost when closing a tab with a Playground instance.
• All changes will be lost when refreshing the page.
• A fresh instance is created each time the link below is clicked.
• Every time this pull request is updated, a new ZIP file containing all changes is created. If changes are not reflected in the Playground instance,
  it's possible that the most recent build failed, or has not completed. Check the list of workflow runs to be sure.

For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation.

Test this pull request with WordPress Playground.

[ramonjd]

Thanks for getting this alternative up. Looks like a simple approach.

I've closed #6008

Also checked manually in the site editor. Global styles endpoint is being called and loaded correctly.

// in the console
await wp.data.select( 'core' ).getEntityRecord( 'root', 'globalStyles', await wp.data.select( 'core' ).__experimentalGetCurrentGlobalStylesId() 

If we get this in, I'll rebase:

• Global styles controllers: extend with WP_REST_Posts_Controller and WP_REST_Revisions_Controller  #5699

Hopefully that'll be baked and ready to go too.

Thanks a lot!

[ramonjd]

Could we hang this one onto https://core.trac.wordpress.org/ticket/60131 as well? I can update the trac description if so. Cheers.

[ramonjd]

We still need the changes in:

• Global styles controllers: extend with WP_REST_Posts_Controller and WP_REST_Revisions_Controller  #5699

did you mean to close that PR and incorporate its changes them into this PR?

[ramonjd]

LGTM (again) 😄

To clarify my last review comment, #5699 extends the Global styles revisions controller with WP_REST_Revisions_Controller - changes that are not covered by this PR.

I assumed the closing comment in #5699 meant that this PR was going to carry over its commits.

All good. Either we reopen #5699 or I can create a new PR with the same changes after this PR lands.

Cheers!