Disable post meta/term cache updating for wp_global_styles

[ocean90]

Neither post metas nor terms are used so this can be disabled to reduce the queries by one.

Trac ticket:

---

This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

[spacedmonkey]

@ocean90 Can you confirm that this does remove queries.

Post meta is loaded. As this post is converted to an array, that loads post meta.

[ocean90]

@spacedmonkey I haven't verified it on a clean install but I got one less term query on a client site. Will check again later, this was just for verifying if there are failing tests.

Though, it makes no sense to convert the post to an array. 😞 Only post_content and ID fields are actually used.

[spacedmonkey]

Though, it makes no sense to convert the post to an array. 😞 Only post_content and ID fields are actually used.

I agree. How about manually converting this to an array. So

$user_cpt = array(
  'ID' => $post->ID, 
  'post_content' => $post->post_content,
);

This is a private method, so it is a little easier to change.

[spacedmonkey]

@ocean90 This code is from gutenberg, it might be better to do this work in the gutenberg repo and it will be backported.

[ocean90]

@ocean90 This code is from gutenberg, it might be better to do this work in the gutenberg repo and it will be backported.

Thanks, created WordPress/gutenberg#45978 as a starting point.

[spacedmonkey]

I have my own PR here - WordPress/gutenberg#46043