Backport: Gutenberg 4434 #3331
Backport: Gutenberg 4434 #3331
Conversation
I think that's accurate; according to unpkg.com, the package currently contains files such as I'll be publishing a new round of npms for WP 6.1 Beta 2 later today, and since we've cherry-picked WordPress/gutenberg#44334 to be included with it, we can check unpkg later to see if the file ended up there. The path you're using to then locate the file in Core after a sync and build also matches where I'm seeing those other CSS files locally. (To recap, we'll need to wait for packages to be published and synced before we can land this PR 😊 ) |
|
Published Here's the sync PR: #3342 |
|
I'll rebase so this will pick up |
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
Co-authored-by: Bernie Reiter <ockham@raz.or.at>
cafcbbc to
e71a7b8
Compare
…ress-develop into backport/gutenberg-44334
There was a problem hiding this comment.
Thank you @scruffian!
Confirming that this enqueues classic.css both on the frontend and in the editor ✅
LGTM!
| // To load classic theme styles on the frontend. | ||
| add_action( 'wp_enqueue_scripts', 'wp_enqueue_classic_theme_styles' ); | ||
| // To load classic theme styles in the the editor. | ||
| add_action( 'admin_enqueue_scripts', 'wp_enqueue_classic_theme_styles' ); |
There was a problem hiding this comment.
I think these should probably be moved to wp-includes/default-filters.php where all other core hooks live. Probably around https://github.com/WordPress/wordpress-develop/blob/trunk/src/wp-includes/default-filters.php#L558
There was a problem hiding this comment.
I'll handle this in the merge though.
|
Some more detail from WordPress/gutenberg#44334 paper trail: WordPress/gutenberg#43981 has testing instructions:
The styling was apparently originally removed by WordPress/gutenberg#34180, which was merged into Gutenberg in June. This means that it likely made its way into Core with the first package sync for WP 6.1. Testing this now. |
Confirming:
|
|
Merged into core in https://core.trac.wordpress.org/changeset/54358. |
This is an attempt at a backport of WordPress/gutenberg#44334
The main part of this change is adding a new CSS file and I'm not sure how to do this - I'm guessing this comes from the packages, rather than me adding it manually.
@ockham any insight would be appreciated.