Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loading RTL CSS files on all RTL sites #3096

Open
wants to merge 1 commit into
base: trunk
Choose a base branch
from

Conversation

farhadsakhaei
Copy link

There is a problem on all RTL sites using block themes and block CSS files
This fixes loading all RTL CSS files and also add suffix to the styles object

This fixes:
https://wordpress.org/support/topic/rtl-problem-bug/
WordPress/gutenberg#41649
WordPress/gutenberg#41762

CC to locale managers:
@naokomc
@tobifjellner

Trac ticket:


This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.

There is a problem on all RTL sites using block themes and block CSS files
This fixes loading all RTL CSS files and also add suffix to the styles object

This fixes:
https://wordpress.org/support/topic/rtl-problem-bug/
WordPress/gutenberg#41649
WordPress/gutenberg#41762

CC to locale managers:
@naokomc
@tobifjellner
@github-actions
Copy link

Hi @farhadsakhaei! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

@sabernhardt
Copy link

Thanks! I posted this to Trac 56325, without the tabs in the empty lines. If you want to remove those tabs here as well, then the PR should pass the PHP coding standards check.

Also, please share your WordPress.org username to receive props on the next release. One way is to add a comment on the Trac ticket.

@farhadsakhaei
Copy link
Author

@sabernhardt
Thank you
I couldn't create a ticket on wp.org because I can't login to wp.org
This is my username: farhad0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants