Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lower the priority of the gallery gap css #2839

Closed

Conversation

glendaviesnz
Copy link

Fixes the order that the Gallery gap CSS is enqueued so it is not overwritten by layout CSS in non block themes.

Merged into Gutenberg trunk and adding here for backporting to WP 6.0.1

Testing

  • In a non-block theme, add a custom CSS var or --wp--style--gallery-gap-default: 37px;
  • Add a Gallery and check in the frontend that the gap is set to 37px
  • Also try and block theme and make sure gap still works as expected

@adamziel
Copy link
Contributor

@glendaviesnz Thank you for preparing this PR! I only realized now that the updated PHP file is in wp-includes/blocks directory which means it's automatically copied from the relevant Gutenberg directory on build. This means we're good and this PR can be closed. Sorry for the trouble!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants