Revisit the bundled block patterns #1103
Conversation
|
Is this patch up to date with what has been merged in Gutenberg? Can we get the phpcs issues fixed? |
It is not! I will get to it tomorrow and be sure that the format is correct |
57f1df4 to
495f8a7
Compare
|
@youknowriad I just updated this with the latest from trunk in Gutenberg. Composer format didn't bring any errors for me. |
| */ | ||
|
|
||
| return array( | ||
| 'title' => _x( 'Heading', 'Block pattern title', 'default' ), |
There was a problem hiding this comment.
I think these 'default' domain arguments should be dropped since we're already on Core.
There was a problem hiding this comment.
Maybe it's fine though. @swissspidy @gziolo do you know what is the guideline for Core?
There was a problem hiding this comment.
It defaults to default so it can be dropped and in practice it usually is.
There was a problem hiding this comment.
Thanks for the heads up, I just removed all of them 👍
|
Committed in r50794. |
This is a follow-up on WordPress/gutenberg#28921 since I discussed with Kjell that this would be better living in core with the rest of the patterns. Follow the discussion on the linked Gutenberg issue for all the details on these patterns. Please Kjell let me know if I should change the wording on the descriptions and titles of these patterns, as well as the categories if the patterns should be organized in a different way.
In order to ensure these patterns will work correctly on any theme, I tested them using Empty Theme, which adds no block CSS and no custom colors to the editor.
Trac ticket: https://core.trac.wordpress.org/ticket/52846
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.