Skip to content

Commit

Permalink
fix vscode-extension bundle step adding correct jspi subfolder (#359)
Browse files Browse the repository at this point in the history
<!-- Thanks for contributing to WordPress Playground Tools! -->

## What?

<!-- In a few words, what is the PR actually doing? Include screenshots
or screencasts if applicable -->

It updates the correct path of `jspi/PHP_*` to be included in the VS
Code extension after upgrading the Playground dependencies on
#350

## Why?

<!-- Why is this PR necessary? What problem is it solving? Reference any
existing previous issue(s) or PR(s), but please add a short summary
here, too -->

The paths to wasm files have changed in the new version.

## How?

<!-- How is your PR addressing the issue at hand? What are the
implementation details? -->

Updating the project bundle step.

## Testing Instructions

<!-- Please include step by step instructions on how to test this PR.
-->
<!-- 1. Check out the branch. -->
<!-- 2. Run a command. -->
<!-- 3. etc. -->

* Run `npx nx run vscode-extension:build:bundle`
* Observe the command finishes successfully : ` > NX Successfully ran
target build:bundle for project vscode-extension (501ms)`
  • Loading branch information
sejas authored Oct 25, 2024
1 parent 3382daa commit a671138
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions packages/vscode-extension/project.json
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,8 @@
"cp ./LICENSE dist/packages/vscode-extension",
"cp packages/vscode-extension/package.json dist/packages/vscode-extension",
"cp packages/vscode-extension/README.md dist/packages/vscode-extension",
"cp -r node_modules/@php-wasm/node/7_* dist/packages/vscode-extension",
"cp -r node_modules/@php-wasm/node/8_* dist/packages/vscode-extension"
"cp -r node_modules/@php-wasm/node/jspi/7_* dist/packages/vscode-extension",
"cp -r node_modules/@php-wasm/node/jspi/8_* dist/packages/vscode-extension"
],
"parallel": false
}
Expand Down

0 comments on commit a671138

Please sign in to comment.