-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block theme: Keep search term when changing categories. #674
Comments
That's the expected behavior, because you navigate top-down, the filters apply in that order— so you can search within a category or filter within a category or search, but clicking a different category goes back to the "top of the funnel". This pattern was established with Showcase. |
Thinking back, I may have brought this up then as well. 😄 I feel like this needs hands-on user testing. I'll try to find some users to test the showcase and report back. |
I agree, the flow makes sense. Search context is a search results page. |
If we don't think this is a legitimate concern, should we at least update the breadcrumb to reflect that context? Currently when I search it goes from:
to
Suggestion
to
|
Describe the bug
We don't persist the search term when you change categories. Adding a keyword is a deliberate action that should persist until the user makes the deliberate action to remove it (which I logged an issue for here #673).
Reproduce
Steps to reproduce the behavior:
Expected
After clicking "All", I should still be filtering based on the search term.
The text was updated successfully, but these errors were encountered: