-
Notifications
You must be signed in to change notification settings - Fork 28
Conversation
ntwb
commented
Feb 22, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, it's nice to see it removed as it doesn't add any value in this context.
lerna.json
Outdated
@@ -1,5 +1,10 @@ | |||
{ | |||
"lerna": "2.9.0", | |||
"command": { | |||
"bootstrap": { | |||
"npmClientArgs": ["--no-package-lock"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need it in the case where we have .npmrc
file with the same flag?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure to be honest, but looking at test/integration/lerna-bootstrap.test.js#L53:
test("--npm-client npm -- --no-optional extends durable npmClientArgs", async () => {
If Lerna is just using the npm
command then Lerna should honor the contents of the .npmrc
file I expect
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed in 56185d5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's still looks good. Seems to use npm
as it is :)