Skip to content
This repository has been archived by the owner on Jul 9, 2018. It is now read-only.

docs: ❤️ Code is Poetry #82

Merged
merged 2 commits into from
Feb 20, 2018
Merged

docs: ❤️ Code is Poetry #82

merged 2 commits into from
Feb 20, 2018

Conversation

ntwb
Copy link
Member

@ntwb ntwb commented Feb 13, 2018

This PR adds the "Code is Poetry" signature used throughout WordPress.org to each packages readme

codeispoetry-wide

@gziolo
Copy link
Member

gziolo commented Feb 14, 2018

Why not this url: https://s.w.org/style/images/codeispoetry.png?1?

@ntwb
Copy link
Member Author

ntwb commented Feb 14, 2018

The image I’ve used was sourced from that image and I added a left margin so that the image appears centred on GitHub README’s

@gziolo
Copy link
Member

gziolo commented Feb 14, 2018

It’s not centered on mobile :) I think you can use img HTML code and GitHub will parse it properly.

@ntwb
Copy link
Member Author

ntwb commented Feb 20, 2018

I've tried all the HTML tricks to have the image centered and cannot make it do so 😢

I also tried the following Markdown tricks to no avail https://stackoverflow.com/q/3912694/1911294

I've pinged the #design team in Slack for some WordPress branding feedback

https://wordpress.slack.com/archives/C02S78ZAL/p1519098547000130

@rmccue
Copy link
Collaborator

rmccue commented Feb 20, 2018

<p align="center"><img src="https://s.w.org/style/images/codeispoetry.png?1" alt="Code is Poetry." /></p>

produces:

Code is Poetry.

@ntwb
Copy link
Member Author

ntwb commented Feb 20, 2018

Thanks @rmccue 💯

me: pretty much speechless 😞 😏

@ntwb ntwb requested a review from gziolo February 20, 2018 06:28
Copy link
Member

@gziolo gziolo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have it 🎉
So you can use more HTML than I would expect :)

@ntwb ntwb merged commit 445072e into master Feb 20, 2018
@ntwb ntwb deleted the add/code-is-poetry branch February 20, 2018 06:45
@rmccue
Copy link
Collaborator

rmccue commented Feb 20, 2018

Legacy attributes = 👌, style attribute or anything sane = 💩 😢

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants