[WIP] Frontend monorepo build dockerfile #3141
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 927 kB ℹ️ View Unchanged
|
|
Thanks for sharing @sarayourfriend, I'm sure there is a lot for me to learn from here. I haven't had the opportunity to check it out yet, but I'll try to do so over the weekend. |
|
Closing this for now. It'd be great to get around to this as a way to simplify (and speed up) the build and even make it possible to run the frontend within the docker compose stack. I'll update the related issue to reflect the approach I started in this PR: #3118 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
@dhruvkb I forgot I had some work done on this and just wanted to get it up in case you were interested in taking a look. It has some issues:
package.jsons and otherpnpm installdependencies, we'd benefit way more heavily from cachingfrontend-prod-depslayer should mount the pnpm store from the base layer instead of using thecachemount type, which is far less reliable than the layer cache (at least in my local testing, I literally couldn't get it to hit even a single time, it always did a full re-download, no matter what I tried... maybe you can figure this out though?)COPY . /appas long as the dockerignore stays configured the way it is now.Even without those changes, it already:
just frontend/upand visitlocalhost:50291. Make changes and it's just running the regular nuxt dev server 🎉Description
Testing Instructions
Checklist
Update index.md).main) or a parent feature branch.Developer Certificate of Origin
Developer Certificate of Origin