Skip to content

Commit

Permalink
Update workflows (#4692)
Browse files Browse the repository at this point in the history
* Update workflows

* Replace type equality checks with `isinstance`

---------

Co-authored-by: Dhruv Bhanushali <dhruv_b@live.com>
  • Loading branch information
openverse-bot and dhruvkb authored Aug 2, 2024
1 parent 49a6fcd commit d423c4b
Show file tree
Hide file tree
Showing 5 changed files with 9 additions and 9 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/pr_label_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ jobs:
- get_label_groups
steps:
- name: Check aspect label
uses: docker://agilepathway/pull-request-label-checker:v1.6.44
uses: docker://agilepathway/pull-request-label-checker:v1.6.48
with:
any_of: ${{ needs.get_label_groups.outputs.aspect }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -55,7 +55,7 @@ jobs:
- get_label_groups
steps:
- name: Check goal label
uses: docker://agilepathway/pull-request-label-checker:v1.6.44
uses: docker://agilepathway/pull-request-label-checker:v1.6.48
with:
one_of: ${{ needs.get_label_groups.outputs.goal }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -68,7 +68,7 @@ jobs:
- get_label_groups
steps:
- name: Check priority label
uses: docker://agilepathway/pull-request-label-checker:v1.6.44
uses: docker://agilepathway/pull-request-label-checker:v1.6.48
with:
one_of: ${{ needs.get_label_groups.outputs.priority }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
Expand All @@ -81,7 +81,7 @@ jobs:
- get_label_groups
steps:
- name: Check stack label
uses: docker://agilepathway/pull-request-label-checker:v1.6.44
uses: docker://agilepathway/pull-request-label-checker:v1.6.48
with:
any_of: ${{ needs.get_label_groups.outputs.stack }}
repo_token: ${{ secrets.GITHUB_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/renovate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ jobs:
sudo chown -R runneradmin:root /tmp/renovate/
ls -R "$cache_dir"
- uses: renovatebot/github-action@v40.1.12
- uses: renovatebot/github-action@v40.2.4
with:
# Renovate recommends _not_ to use any of
# [these names](https://docs.renovatebot.com/configuration-options/).
Expand Down
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ repos:
- id: requirements-txt-fixer

- repo: https://github.com/astral-sh/ruff-pre-commit
rev: v0.5.0
rev: v0.5.5
hooks:
- id: ruff # replaces Flake8, isort, pydocstyle, pyupgrade
args:
Expand Down Expand Up @@ -155,7 +155,7 @@ repos:
files: (.vale/.*|.mdx?)$

- repo: https://github.com/renovatebot/pre-commit-hooks
rev: 37.421.5
rev: 37.440.7
hooks:
- id: renovate-config-validator
args:
Expand Down
2 changes: 1 addition & 1 deletion catalog/dags/providers/provider_api_scripts/smithsonian.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def _check_type(unknown_input, required_type):
if unknown_input is None:
logger.debug(f"{unknown_input} is of type {type(unknown_input)}.")
typed_input = required_type()
elif type(unknown_input) != required_type:
elif not isinstance(unknown_input, required_type):
logger.info(
f"{unknown_input} is of type {type(unknown_input)}"
f" rather than {required_type}."
Expand Down
2 changes: 1 addition & 1 deletion catalog/tests/dags/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ def freeze_time(monkeypatch):

class FreezeMeta(type):
def __instancecheck__(self, instance):
if type(instance) == original or type(instance) == Freeze:
if isinstance(instance, (original, Freeze)):
return True

class Freeze(datetime.datetime):
Expand Down

0 comments on commit d423c4b

Please sign in to comment.