Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix whether moment.js is minified or not based on SCRIPT_DEBUG #918

Merged
merged 1 commit into from
May 26, 2017
Merged

Fix whether moment.js is minified or not based on SCRIPT_DEBUG #918

merged 1 commit into from
May 26, 2017

Conversation

nylen
Copy link
Member

@nylen nylen commented May 26, 2017

The conditional for determining whether to load the minified or unminified version of moment.js is reversed, see #841.

@nylen nylen added the [Type] Bug An existing feature does not function as intended label May 26, 2017
@nylen nylen requested a review from youknowriad May 26, 2017 21:33
BE-Webdesign
BE-Webdesign approved these changes May 26, 2017
View reviewed changes
Copy link
Contributor

@BE-Webdesign BE-Webdesign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

youknowriad
youknowriad approved these changes May 26, 2017
View reviewed changes
Copy link
Contributor

@youknowriad youknowriad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙃

@nylen nylen merged commit f784d3e into master May 26, 2017
@nylen nylen deleted the fix/moment-script-debug branch May 26, 2017 21:44
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Mar 25, 2024
Open
@yassine4999 yassine4999 mentioned this pull request Mar 26, 2024
Open
@Verdinjoshua26 Verdinjoshua26 mentioned this pull request Mar 26, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BE-Webdesign BE-Webdesign BE-Webdesign approved these changes

@youknowriad youknowriad youknowriad approved these changes

Assignees
No one assigned
Labels
[Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nylen @youknowriad @BE-Webdesign