Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary comma (,) #9119

Closed
wants to merge 1 commit into from
Closed

Remove unnecessary comma (,) #9119

wants to merge 1 commit into from

Conversation

nitishkaila
Copy link
Contributor

@nitishkaila nitishkaila commented Aug 18, 2018

Description

Remove unnecessary comma (,)

How has this been tested?

Screenshots

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@chrisvanpatten
Copy link
Contributor

chrisvanpatten commented Aug 18, 2018

Thanks for your contribution @nitishkaila!

At this time, we enforce comma dangles in the eslint configuration. The commas are technically unnecessary, but they make for cleaner diffs and provide consistency between the PHP coding standards which also enforce comma dangling. There's some discussion about this in #612 and #741.

Because of that, I'm going to close this out but thank you again for the contribution! 🚀

@chrisvanpatten chrisvanpatten added the [Type] Code Quality Issues or PRs that relate to code quality label Aug 18, 2018
@chrisvanpatten chrisvanpatten added the [Status] Not Implemented Issue/PR we will (likely) not implement. label Aug 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Not Implemented Issue/PR we will (likely) not implement. [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants