Framework: Fix typo for removing excerpt block stripping #9093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
approved these changes
Aug 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9084
Regression introduced in #8984
This pull request seeks to resolve an issue where a filter which was responsible for stripping dynamic blocks from excerpts was never properly removed. The original implementation appears to have intended to temporarily add a filter for excerpts, but due to what I'm attributing to be a typo, it was never removed because it had specified the incorrect function name. Prior to these changes, the
strip_dynamic_blocks_remove_filterwas an unused function.Testing instructions:
Repeat steps to reproduce from #9084, verifying that Latest Posts appears as expected with the Yoast plugin activated.