i18n: Use argument swapping instead of named arguments for string placeholders #8771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I realized that translator comment for the last two strings is wrong, and that those strings can actually use |
aduth
approved these changes
Aug 13, 2018
| position, | ||
| } | ||
| // translators: 1: Number of selected blocks, 2: Position of selected blocks | ||
| _n( |
There was a problem hiding this comment.
If I had to guess, this was previously using __ because we'd never be showing these controls except if there were more than one block selected. I get the sense that even still we'd want to use _n (e.g. non-English pluralization?) as you've proposed here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In WordPress, argument swapping is used in strings with placeholders. This PR switches from named arguments introduced in 73edbd4, and also adds translators comments to affected strings.
See #984 (review)