Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo: Remove extra 'the' #7677

Closed
wants to merge 3 commits into from
Closed

Conversation

burhandodhy
Copy link
Contributor

Description

Fix typo : Remove extra 'the' in core-edit-post.md

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@Soean
Copy link
Member

Soean commented Jul 3, 2018

Hey @burhandodhy
nice catch. The docs are generated from the source code. So you have to edit the source file: https://github.com/WordPress/gutenberg/blob/master/edit-post/store/selectors.js

@Soean Soean added the [Type] Developer Documentation Documentation for developers label Jul 3, 2018
@burhandodhy
Copy link
Contributor Author

Thanks, Soean

It is fixed now.

@Soean
Copy link
Member

Soean commented Jul 3, 2018

@burhandodhy To remove the space after ## Selectors you also have to change the source code: https://github.com/WordPress/gutenberg/blob/master/docs/tool/generator.js#L68

I think you can regenerate the docs from the source code with npm run docs:build?

@burhandodhy
Copy link
Contributor Author

Done

Copy link
Member

@Soean Soean left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I think the PR is fine now.

@gziolo
Copy link
Member

gziolo commented Jul 3, 2018

It needs another rebase because we had to change the way generated files are named. Sorry about that. Once it is done, we can merge it. Thanks for working on it 🎉

@Soean
Copy link
Member

Soean commented Jul 26, 2018

@burhandodhy Can you do a rebase or open a new PR?

@gziolo gziolo added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jul 26, 2018
@danielbachhuber
Copy link
Member

Landing with #9238

Thanks again for your work on this, @burhandodhy.

burhandodhy added a commit to burhandodhy/gutenberg that referenced this pull request Aug 24, 2018
gziolo pushed a commit that referenced this pull request Aug 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants