Rich Text: Remove createUndoLevel for split, merge #7650
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4956 (comment)
This pull request seeks to optimize
RichText
by removing the creation of undo levels at split and merge steps. These have the adverse effect of causing the field'sonChange
callback to be called needlessly.These changes introduce new, very basic end-to-end tests to verify against regression in undo behaviors on splitting.
Testing instructions:
Verify there are no regressions in splitting or merging blocks (e.g. paragraph), and that undo-ing still has the desired effect.
Ensure end-to-end tests pass: