-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block API: Add block styles variations API #7362
Merged
Merged
Changes from 1 commit
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
f972ed8
Block API: Add block styles variation API
youknowriad b239ceb
Adding some unit tests
youknowriad df5ac6d
Fix unit tests
youknowriad 0354f96
Fix e2e tests
youknowriad f6ccf0c
Update the block switcher UI to show style variations and previews
youknowriad 7bc5ad7
Always open the block transforms panel and avoid leaking the text-align
youknowriad f498532
Use the same inserterg grid view for block transforms
youknowriad 4453d7d
Fix unit tests
youknowriad 91c85d4
Add style variations e2e test
youknowriad 25822af
Use block icon with colors in main block toolbar.
mtias 3023b50
Adjust padding of block switcher chip to avoid toolbar clipping.
mtias 5ceb5da
Center preview for block styles.
mtias e5bd680
Use button to ensure valid HTML
youknowriad 50cbfd0
Fix lint
youknowriad 07f1b24
Add alternate styles for separator.
mtias e4d56da
Show style variations when the block type doesn't have any block tran…
youknowriad 904eb3b
Improve a11y of the style switcher
youknowriad da71ec9
Add Button block style variants and fix line height.
mtias 99a27a8
Polish the visuals a bit.
jasmussen 409e28d
Fix tabs/spaces.
jasmussen 1b9a9fc
Fix keyboard navigation into the styles preview buttons
youknowriad 5449188
Polish preview container, fix focus, separator
jasmussen 20e460e
Adding the is-active className to the block-styles component
youknowriad ac3ab56
Move the styles BlockAPI to the root level (out of the transforms)
youknowriad 91c8900
Rename CSS class to utilize is-active.
jasmussen 616731d
Showing style variation labels
youknowriad 295b608
Polish the separator styles
052922c
Fix grid items width
youknowriad 252a3fc
Use proper label names for quote styles.
mtias 837295a
Polish separator styles for frontend
8c0db3a
Add button outline style.
mtias d720cab
Fix unit tests (Block Switcher without blocks)
youknowriad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update the block switcher UI to show style variations and previews
- Loading branch information
commit f6ccf0cf3c10b958bb11db8670f936fab6c25c5e
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a very expected API 👍