Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spacer: Adjust to inherit display and flex properties #68890

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from

Conversation

yogeshbhutkar
Copy link
Contributor

@yogeshbhutkar yogeshbhutkar commented Jan 27, 2025

What, Why and How?

Fixes: #68889

This PR addresses a bug where the Spacer block fails to fill the available space when the height is set to "Grow" within a stack block with a defined minimum height. Instead of expanding, the Spacer block's height incorrectly becomes 0.

Testing Instructions

  1. Create a stack block.
  2. Set the minimum height of the block to 500px.
  3. Add a spacer block within it.
  4. Set the height of the spacer block to Grow.
  5. Observe the height properly reflects the available space.

Screenshots or screencast

Screen.Recording.2025-01-27.at.1.22.23.PM.mov
Before After
before after

@yogeshbhutkar yogeshbhutkar marked this pull request as ready for review January 27, 2025 08:20
Copy link

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: yogeshbhutkar <yogeshbhutkar@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@yogeshbhutkar
Copy link
Contributor Author

I believe the failing tests are unrelated to the changes introduced in this PR.

@yogeshbhutkar yogeshbhutkar force-pushed the fix-68889/spacer-block-height-grow branch from 19c8c0c to d1de345 Compare January 28, 2025 04:52
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended [Block] Spacer Affects the Spacer Block labels Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Spacer Affects the Spacer Block [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Spacer block does not stretch the height to fill the available space
2 participants