Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Update links to HTTPS #68888

Merged
merged 3 commits into from
Jan 29, 2025

Conversation

SainathPoojary
Copy link
Contributor

@SainathPoojary SainathPoojary commented Jan 27, 2025

Related: #68883
Related to: #68882

What?

Updated all hardcoded HTTP links in the codebase to use HTTPS where applicable.

Why?

Ensuring links use HTTPS improves security by encrypting data transmission, aligns with modern web standards, and prevents potential mixed content warnings on HTTPS-enabled sites. This update addresses outdated HTTP links to enhance user trust and data protection.

How?

  • Searched the codebase for all instances of http:// links.
  • Verified whether the corresponding HTTPS versions of the links are valid and accessible.
  • Replaced all valid http:// links with https:// equivalents.
  • Skipped any links that do not support HTTPS or are intentionally left as HTTP.

Testing Instructions

  1. Review the modified files to confirm all instances of http:// links have been appropriately replaced with https://.
  2. Verify that the replaced links are functional by navigating to them in a browser.
  3. Check for any unintended consequences (e.g., broken URLs or incorrect replacements) in the impacted files.

Copy link

github-actions bot commented Jan 27, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: SainathPoojary <sainathpoojary@git.wordpress.org>
Co-authored-by: t-hamano <wildworks@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@shail-mehta shail-mehta added the [Type] Developer Documentation Documentation for developers label Jan 27, 2025
@shail-mehta
Copy link
Member

shail-mehta commented Jan 27, 2025

@SainathPoojary Thanks for the PR.

I think Its Not Follow up of #68883 its Related PR.

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

Some links have redirects applied to them so I think we need to write the final URL.

packages/babel-plugin-import-jsx-pragma/README.md Outdated Show resolved Hide resolved
packages/babel-plugin-import-jsx-pragma/README.md Outdated Show resolved Hide resolved
packages/eslint-plugin/README.md Outdated Show resolved Hide resolved
@SainathPoojary
Copy link
Contributor Author

Hey @t-hamano,

I’ve made all the suggested changes and added a few additional improvements. Please have a look whenever you have a moment. Thanks for the review!

Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@t-hamano t-hamano merged commit 41deebd into WordPress:trunk Jan 29, 2025
63 checks passed
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants