Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline Commenting: Change the PHP compat directory #68846

Merged
merged 4 commits into from
Jan 23, 2025

Conversation

Mamaduka
Copy link
Member

@Mamaduka Mamaduka commented Jan 23, 2025

What?

See #68712 (comment).

PR moves PHP files related to the inline commenting to the experimental directory.

Why?

The feature is experimental and not targeted for WP 6.8.

Testing Instructions

  1. Navigate to Gutenberg > Experiments
  2. Enable "multi-user block level commenting" experiment.
  3. Confirm inline commenting works for blocks as before.

Testing Instructions for Keyboard

Same.

Screenshots or screencast

CleanShot 2025-01-23 at 12 32 17

@Mamaduka Mamaduka added [Type] Code Quality Issues or PRs that relate to code quality Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows labels Jan 23, 2025
@Mamaduka Mamaduka self-assigned this Jan 23, 2025
Copy link

github-actions bot commented Jan 23, 2025

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Co-authored-by: Mamaduka <mamaduka@git.wordpress.org>
Co-authored-by: shail-mehta <shailu25@git.wordpress.org>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

@Mamaduka Mamaduka added the No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core label Jan 23, 2025
Copy link
Member

@shail-mehta shail-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@peterwilsoncc peterwilsoncc merged commit 654bace into trunk Jan 23, 2025
68 of 69 checks passed
@peterwilsoncc peterwilsoncc deleted the update/block-comments-compat-directory branch January 23, 2025 22:06
@github-actions github-actions bot added this to the Gutenberg 20.2 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Collaborative Workflows Phase 3 of the Gutenberg roadmap around all-things related to collaborative workflows No Core Sync Required Indicates that any changes do not need to be synced to WordPress Core [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants