-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Site Editor Template part is missing an icon in the sidebar #68653
base: trunk
Are you sure you want to change the base?
Fix: Site Editor Template part is missing an icon in the sidebar #68653
Conversation
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.
To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
test/integration/fixtures/blocks/core__separator-custom-color.json
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @dhananjaykuber!
Fixes #68649
What?
Fixes the missing icon display for Template Parts in the Site Editor's document settings sidebar by implementing proper icon mapping for template part areas.
Why?
After #66459, the document settings sidebar stopped displaying icons for Template Parts because the icon value returned from default_template_part_areas was a string that wasn't properly mapped to a WordPress icon component. This PR restores the icon display functionality.
Testing Instructions
Screenshots or screencast