Block Editor: Add documentation for SpacingSizesControl component #68581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
stokesman
reviewed
Jan 20, 2025
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
stokesman
reviewed
Jan 20, 2025
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
|
Hi @stokesman, |
stokesman
reviewed
Jan 25, 2025
packages/block-editor/src/components/spacing-sizes-control/index.js
Outdated
Show resolved
Hide resolved
- Removed unnecessary props and wrappers - Added proper state management with useState hook - Ensured consistent documentation between the component and README - Replaced SpacerBlock with Example component - Added proper imports for SpacingSizesControl and useState - Removed unnecessary View wrapper and optional props - Updated README to match the new implementation
stokesman
reviewed
Jan 27, 2025
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/spacing-sizes-control/index.js
Outdated
Show resolved
Hide resolved
packages/block-editor/src/components/spacing-sizes-control/README.md
Outdated
Show resolved
Hide resolved
- Removed redundant description section in README - Consolidated component description into a single paragraph - Updated import examples to use `__experimentalSpacingSizesControl` alias - Removed screenshot reference - Standardized prop descriptions
|
Hi @stokesman, |
stokesman
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: #22891
Closes: #52070
What?
Adds documentation for the SpacingSizesControl component by:
Why?
The SpacingSizesControl component currently lacks documentation, making it difficult for developers to understand and implement the component correctly:
The documentation follows established patterns from other components while providing specific details relevant to SpacingSizesControl, making it easier for developers to use this component effectively in their blocks.